Skip to content

Qualcomm AI Engine Direct - Intermediate Tensor Dump #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

winskuo-quic
Copy link
Collaborator

Summary

  • Intermediate Tensor Dump enablement
  • Added UT for intermediate tensor dump

Copy link

pytorch-bot bot commented Sep 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5310

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 40e3532 with merge base eb0cdf7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
This PR is to enable intermediate tensor dump. Please have a look.
Thanks

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Sep 13, 2024

Hi @winskuo-quic , there is an internal build failure, could you apply this patch and update again?

--- a/executorch/backends/qualcomm/runtime/targets.bzl
+++ b/executorch/backends/qualcomm/runtime/targets.bzl
@@ -63,5 +63,6 @@
             "//executorch/backends/qualcomm/aot/wrappers:wrappers",
             "//executorch/runtime/backend:interface",
             "//executorch/runtime/core:core",
+            "//executorch/extension/tensor:tensor",
         ],
     )

@winskuo-quic
Copy link
Collaborator Author

Hi @winskuo-quic , there is an internal build failure, could you apply this patch and update again?

--- a/executorch/backends/qualcomm/runtime/targets.bzl
+++ b/executorch/backends/qualcomm/runtime/targets.bzl
@@ -63,5 +63,6 @@
             "//executorch/backends/qualcomm/aot/wrappers:wrappers",
             "//executorch/runtime/backend:interface",
             "//executorch/runtime/core:core",
+            "//executorch/extension/tensor:tensor",
         ],
     )

Hi @cccclai,
Thanks for reviewing the PR. I have just pushed a new commit that has your patch applied.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Sep 13, 2024

Sorry I'm having issues on merging, could you rebase?

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/intermediate_tensor_etdump branch from a85f868 to 40e3532 Compare September 15, 2024 08:29
@winskuo-quic
Copy link
Collaborator Author

Hi @cccclai,
I have just rebased to mainline.
Thanks

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cccclai merged this pull request in eecf74f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants