Skip to content

Update Codegen.cmake for improved Python package path handling #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

Update Codegen.cmake for improved Python package path handling #6730

merged 1 commit into from
Apr 1, 2025

Conversation

AkiSakurai
Copy link
Contributor

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6730

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 28 Pending

As of commit 0117530 with merge base bc3d437 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 8, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 7, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Jan 7, 2025
malfet
malfet reviewed Jan 14, 2025
View reviewed changes
@mcr229 mcr229 mentioned this pull request Jan 21, 2025
Open
@mergennachin mergennachin mentioned this pull request Feb 4, 2025
Merged
@shoumikhin
Copy link
Contributor

@larryliu0820, @lucylq can you take a look please?

@mergennachin
Copy link
Contributor

Hi @AkiSakurai -- would you mind rebasing? Looks like there's a conflict

@larryliu0820
Copy link
Contributor

build/Codegen.cmake has been moved to tools/cmake/Codegen.cmake.

larryliu0820
larryliu0820 reviewed Mar 17, 2025
View reviewed changes
build/Codegen.cmake Outdated
Comment on lines 83 to 85
OUTPUT_VARIABLE site-packages-out
ERROR_VARIABLE site-packages-out-error
RESULT_VARIABLE site-packages-result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change these names to torchgen-out, torchgen-out-error and torchgen-result

@byjlw
Copy link
Contributor

byjlw commented Mar 31, 2025

@AkiSakurai can you rebase and handle the file move?

build/Codegen.cmake has been moved to tools/cmake/Codegen.cmake.

@AkiSakurai
Update Codegen.cmake for improved Python package path handling
0117530 
- Modified the method of retrieving the Python site-packages path to use `importlib.util.find_spec` for better compatibility.
- fix pytorch#6689
@mergennachin mergennachin merged commit 5f01843 into pytorch:main Apr 1, 2025
165 of 167 checks passed
@mergennachin
Copy link
Contributor

Thank you @AkiSakurai for your contribution

kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
@AkiSakurai @kirklandsign
Update Codegen.cmake for improved Python package path handling (#6730)
1946c3d 
- Modified the method of retrieving the Python site-packages path to use
`importlib.util.find_spec` for better compatibility.
- fix #6689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 left review comments

@malfet malfet malfet approved these changes

@dbort dbort Awaiting requested review from dbort

@mergennachin mergennachin Awaiting requested review from mergennachin

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@swolchok swolchok Awaiting requested review from swolchok

@digantdesai digantdesai Awaiting requested review from digantdesai

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
7 participants
@AkiSakurai @shoumikhin @mergennachin @larryliu0820 @byjlw @malfet @facebook-github-bot