[mps] dim_order Fix #7563
Merged
[mps] dim_order Fix #7563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
digantdesai
force-pushed
the
mps_dim_order
branch
from
615248f to
cf283b5
Compare
digantdesai
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
Differential Revision: D67542995
digantdesai
force-pushed
the
mps_dim_order
branch
from
cf283b5 to
a76c53f
Compare
digantdesai
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
digantdesai
force-pushed
the
mps_dim_order
branch
from
a76c53f to
435fcb6
Compare
digantdesai
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
digantdesai
added
the
module: mps
digantdesai
force-pushed
the
mps_dim_order
branch
from
435fcb6 to
08d2349
Compare
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
digantdesai
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
JacobSzwejbka
approved these changes
Jan 10, 2025
digantdesai
had a problem deploying
to
upload-benchmark-results
GitHub Actions
Failure
|
@pytorchbot cherry-pick --onto release/0.5 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Jan 14, 2025
Add dim_order compat support Differential Revision: D67542995 (cherry picked from commit 8975f15)
Cherry picking #7563The cherry pick PR is at #7661 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
SS-JIA
pushed a commit
that referenced
this pull request
Jan 15, 2025
[mps] dim_order Fix (#7563) Add dim_order compat support Differential Revision: D67542995 (cherry picked from commit 8975f15) Co-authored-by: Digant Desai <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Add dim_order compat support Differential Revision: D67542995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for dim_order for mps preprocess, by reverting the dim_order ops back to the memory_format ops temporarily. This will also turn on dim_order for mps tests.