-
Notifications
You must be signed in to change notification settings - Fork 542
use dim order in arm test #7697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: as title Differential Revision: D68177095
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7697
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 77cc1c4 with merge base 0dba025 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D68177095 |
@pytorchbot label "topic: not user facing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with this, I will let @oscarandersson8218 stamp this given there is some history behind dim_order support in arm delegate.
@digantdesai @Gasoonjia Looks good to me. In order to actually test this we need to flip the switch in the Tester base class as well. When I did, I found failures for our to_copy tests. I have a fix for it internally which should be upstreamed soon. Can you park this PR until then? @digantdesai: @oscarandersson8218, since you are already fixing this, alternatively you can commandeer this PR (or create a new one) and take care of arm delegate dim order enablement? @oscarandersson8218: @digantdesai Yes, I can add the changes of this PR to my change. |
@digantdesai @Gasoonjia Moved this to #7831 along with other fixes. |
Hi @Gasoonjia the #7831 PR has been merged, is it OK to close this PR? |
@zingo |
The same, the thanks on our side should go to @oscarandersson8218 I just pressed submit 😂 |
Summary: as title
Differential Revision: D68177095
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218