Skip to content

use dim order in arm test #7697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jan 16, 2025

Summary: as title

Differential Revision: D68177095

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Summary: as title

Differential Revision: D68177095
Copy link

pytorch-bot bot commented Jan 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7697

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 77cc1c4 with merge base 0dba025 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68177095

@Gasoonjia
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@digantdesai digantdesai added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 16, 2025
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this, I will let @oscarandersson8218 stamp this given there is some history behind dim_order support in arm delegate.

@oscarandersson8218
Copy link
Collaborator

oscarandersson8218 commented Jan 17, 2025

@digantdesai @Gasoonjia Looks good to me. In order to actually test this we need to flip the switch in the Tester base class as well. When I did, I found failures for our to_copy tests. I have a fix for it internally which should be upstreamed soon. Can you park this PR until then?

@digantdesai: @oscarandersson8218, since you are already fixing this, alternatively you can commandeer this PR (or create a new one) and take care of arm delegate dim order enablement?

@oscarandersson8218: @digantdesai Yes, I can add the changes of this PR to my change.

@oscarandersson8218
Copy link
Collaborator

@digantdesai @Gasoonjia Moved this to #7831 along with other fixes.

@zingo
Copy link
Collaborator

zingo commented Jan 23, 2025

Hi @Gasoonjia the #7831 PR has been merged, is it OK to close this PR?

@Gasoonjia
Copy link
Contributor Author

@zingo
Thanks for working on dim order! Closing it.

@Gasoonjia Gasoonjia closed this Jan 23, 2025
@zingo
Copy link
Collaborator

zingo commented Jan 23, 2025

The same, the thanks on our side should go to @oscarandersson8218 I just pressed submit 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants