Skip to content

[Arm] TOSA reference model update #7699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/0.5
Choose a base branch
from

Conversation

per
Copy link
Collaborator

@per per commented Jan 16, 2025

Update TOSA reference model to v0.80.1 tag to get fixes for numpy=2.0.0

Copy link

pytorch-bot bot commented Jan 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7699

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 84dfaa9 with merge base 9069017 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2025
@@ -88,7 +88,7 @@ ethos_u_base_rev="24.08"

# tosa reference model
tosa_reference_model_url="https://review.mlplatform.org/tosa/reference_model"
tosa_reference_model_rev="c5570b79e90c3a36ab8c4ddb8ee3fbc2cd3f7c38"
tosa_reference_model_rev="v0.80.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, how did you figure this out?

@digantdesai
Copy link
Contributor

can we try with pulling #7670 as well? on release/0.5?

mergennachin and others added 3 commits January 16, 2025 22:28
Upgrade numpy version requirement to

Summary:

1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0

We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip

We had to upgrade to the latest transformers as well

(cherry picked from commit a7b5297)
(cherry picked from commit a18f6e8)
Update TOSA reference model to latest tag on 0.80 branch to get fixes
for numpy==2.0.0

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I18de47807bd307b3919f44a67c36d42da0759f49
@per per force-pushed the tosa_ref_model_update branch from 37528fd to 84dfaa9 Compare January 16, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants