install_requirements.py: use argparse, minor cleanup #7703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7703
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 1d4dfab with merge base 1b7b10e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jan 16, 2025
mergennachin
approved these changes
Jan 16, 2025
install_requirements.py
Outdated
| elif arg == "--use-pt-pinned-commit": | ||
| for pybind_arg in args.pybind: | ||
| if pybind_arg not in ["coreml", "mps", "xnnpack"]: | ||
| continue |
There was a problem hiding this comment.
raise exception here?
There was a problem hiding this comment.
whoops! I misinterpreted the original code after I'd made some modifications to it. will fix.
install_requirements.py
Outdated
| EXECUTORCH_BUILD_PYBIND = "ON" | ||
| CMAKE_ARGS += f" -DEXECUTORCH_BUILD_{pybind_arg.upper()}=ON" | ||
|
|
||
| if args.clean: |
There was a problem hiding this comment.
do this if statement first?
swolchok
added
the
release notes: build
This was referenced Jan 16, 2025
digantdesai
pushed a commit
that referenced
this pull request
Jan 17, 2025
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the bespoke argument parser with argparse in preparation for separating requirements installation from building and installing ExecuTorch itself.
Test Plan: (with debug print of args.pybind to save time)
install_requirements.sh --pybind xnnpack --pybind mps --pybind coreml
install_requirements.sh --pybind xnnpack mps coreml
install_requirements.sh --clean
CI should cover use-pt-pinned-commit