Add a pass to remove certain redundant branched quant/dequant nodes #8896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8896
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a77b024 with merge base 24671a9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69947096 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D69947096 |
Vysarat
force-pushed
the
export-D69947096
branch
from
a038391 to
d533abd
Compare
…ytorch#8896) Summary: This pass addresses situations like this, where the `quantize` and `dequantize` nodes have the same parameters: ``` some_op0 | quantize / \ some_op1 dequantize | some_op2 ``` . We can eliminate `dequantize` like so: ``` some_op0 / \ quantize some_op2 / some_op1 ``` The same logic is applied when the order of `quantize` and `dequantized` is reversed. Situations where the `some_op1` branch doesn't exist are handled by `FuseQuantDequantToRequantizePass`, but branched scenarios require different logic. Differential Revision: D69947096
Vysarat
force-pushed
the
export-D69947096
branch
from
d533abd to
a77b024
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69947096 |
zonglinpeng
approved these changes
Mar 3, 2025
zonglinpeng
pushed a commit
that referenced
this pull request
Mar 6, 2025
Differential Revision: D69947096 Pull Request resolved: #8896
This was referenced Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pass addresses situations like this, where the
quantizeanddequantizenodes have the same parameters:. We can eliminate
dequantizelike so:The same logic is applied when the order of
quantizeanddequantizedis reversed.Situations where the
some_op1branch doesn't exist are handled byFuseQuantDequantToRequantizePass, but branched scenarios require different logic.Differential Revision: D69947096