Skip to content

[ET-VK] Allow memory tagging pass to handle nodes with list of tensor args #9203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #9173 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/196/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/196/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/196/orig
@diff-train-skip-merge

… args

## Context

Currently, the memory metadata tagging pass cannot properly insert memory type transitions for operators that accept a list of tensors as an input argument.

This diff addresses the gap by implementing the case where a graph node's argument is a list of nodes instead of just a single node.

Differential Revision: [D71005186](https://our.internmc.facebook.com/intern/diff/D71005186/)

ghstack-source-id: 271146751
Pull Request resolved: #9173
@pytorchbot pytorchbot requested a review from SS-JIA as a code owner March 12, 2025 20:56
Copy link

pytorch-bot bot commented Mar 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9203

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2025
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@SS-JIA SS-JIA merged commit 791fe7f into main Mar 12, 2025
45 of 47 checks passed
@SS-JIA SS-JIA deleted the gh/SS-JIA/196/orig branch March 12, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants