Skip to content

Enable model based selective build on xplat #9205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

larryliu0820
Copy link
Contributor

Summary:
As titled. This is to be able to build things like:

 manifold_get(
        name = "asr_cpu_model",
        out = "asr.ff",
        api_key = "speech_pytorch_edge_models-key",
        artifact_path = "tree/resources/asr/speech_tuna_supernova_ondevice_en_us_fakequant_9647d4e983236f0769d804556f648380/1740444706624/asr.ff",
        bucket_name = "speech_pytorch_edge_models",
        sha1 = "4104089609f4d73f7c5d44d33f3a0e86636bd526",
        timeout_msec = 100000000,
        visibility = ["PUBLIC"],
    )

    # This should give you a list of operators that are being used in model.pte, along with dtype information.
    et_operator_library(
        name = "asr_model_ops",
        model = ":asr_cpu_model",
    )

In xplat.

Reviewed By: seayoung1112

Differential Revision: D71070646

Summary:
As titled. This is to be able to build things like:


```
 manifold_get(
        name = "asr_cpu_model",
        out = "asr.ff",
        api_key = "speech_pytorch_edge_models-key",
        artifact_path = "tree/resources/asr/speech_tuna_supernova_ondevice_en_us_fakequant_9647d4e983236f0769d804556f648380/1740444706624/asr.ff",
        bucket_name = "speech_pytorch_edge_models",
        sha1 = "4104089609f4d73f7c5d44d33f3a0e86636bd526",
        timeout_msec = 100000000,
        visibility = ["PUBLIC"],
    )

    # This should give you a list of operators that are being used in model.pte, along with dtype information.
    et_operator_library(
        name = "asr_model_ops",
        model = ":asr_cpu_model",
    )
```

In xplat.

Reviewed By: seayoung1112

Differential Revision: D71070646
@larryliu0820 larryliu0820 requested a review from lucylq as a code owner March 12, 2025 21:37
Copy link

pytorch-bot bot commented Mar 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9205

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e61cd6b with merge base 791fe7f (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71070646

Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot facebook-github-bot merged commit ebea003 into main Mar 13, 2025
50 of 55 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D71070646 branch March 13, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants