Skip to content

Updates docs to reflect changes in CoreML #9645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2025
Merged

Updates docs to reflect changes in CoreML #9645

merged 7 commits into from
Mar 26, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented Mar 26, 2025

Summary

Test plan

Read

@jathu jathu requested a review from GregoryComer March 26, 2025 15:53
Copy link

pytorch-bot bot commented Mar 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9645

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending

As of commit ec4b513 with merge base 46937eb (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 26, 2025
@jathu jathu marked this pull request as ready for review March 26, 2025 15:55
@jathu jathu requested review from byjlw and larryliu0820 March 26, 2025 16:00
Base automatically changed from jathu/include-inmemoryfs to main March 26, 2025 19:04
@jathu jathu force-pushed the jathu/update-docs branch from 8a73dc0 to ec4b513 Compare March 26, 2025 19:05
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@jathu jathu merged commit 74e4308 into main Mar 26, 2025
87 of 88 checks passed
@jathu jathu deleted the jathu/update-docs branch March 26, 2025 20:10
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
### Summary

* After #9483, we should have
CoreML support out of the box for macOS
* Unfortunately, we still need
`backends/apple/coreml/scripts/install_requirements.sh` to use the
[coreml_executorch_runner](https://github.com/pytorch/executorch/tree/main/examples/apple/coreml/executor_runner)
(used for testing)
* I should have caught all the usage

### Test plan
Read
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants