Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm backend: Add pre-push checks for op tests #9899

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Apr 4, 2025

  • Check that @SkipIfNoCorstone is not used
  • Check that @expectedFailureOnFVP is not used
  • Check that unittest.TestCase is not used
  • Check that on_fvp suffix is not used
  • Check that op and target is parsed from the test name

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

- Check that @SkipIfNoCorstone is not used
- Check that @expectedFailureOnFVP is not used
- Check that unittest.TestCase is not used
- Check that on_fvp suffix is not used
- Check that op and target is parsed from the test name

Change-Id: I7c25783ff3b5a75fe7ea96c7aeca3008813ee277
Signed-off-by: Adrian Lundell <[email protected]>
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 4, 2025
Copy link

pytorch-bot bot commented Apr 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9899

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 78f1666 with merge base db21501 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2025
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zingo zingo merged commit 1e97232 into pytorch:main Apr 8, 2025
167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants