[Executorch][SDPA] Remove slice creation #9911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
requested review from
jackzhxng,
iseeyuan,
larryliu0820 and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9911
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
approved these changes
Apr 4, 2025
Not needed because the only reason we were slicing was to get sliced seqlen of k and v that is used for causal attention. Differential Revision: [D71370595](https://our.internmc.facebook.com/intern/diff/D71370595/) ghstack-source-id: 276012275 Pull Request resolved: #9888
kirklandsign
force-pushed
the
gh/kimishpatel/168/orig
branch
from
352a666 to
16a8d9e
Compare
This PR needs a
|
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Not needed because the only reason we were slicing was to get sliced seqlen of k and v that is used for causal attention. Differential Revision: [D71370595](https://our.internmc.facebook.com/intern/diff/D71370595/) ghstack-source-id: 276012275 Pull Request resolved: #9888
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #9888 by @kimishpatel
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/168/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/168/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/167/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/168/orig
@diff-train-skip-merge