Skip to content

Disable pybind11's GIL checks #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Disable pybind11's GIL checks #325

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c94d324
Update CMakeLists.txt
EthanSteinberg Jul 16, 2023
50fb247
Update CMakeLists.txt
EthanSteinberg Jul 16, 2023
e1ebd07
Update CMakeLists.txt
EthanSteinberg Jul 16, 2023
6c3f4b8
Update CMakeLists.txt
EthanSteinberg Jul 16, 2023
0491001
Update CMakeLists.txt
EthanSteinberg Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions multipy/runtime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ project(MultipyRuntime)
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

# multipy currently does not pass pybind11's GIL checks.
#
# This usually indicates undefined behavior or bugs within extensions, but we don't have the resources to debug
# this package right now.
#
# In the future, someone should find out why this code fails to work when these checks are enabled.
add_definitions(-DPYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF)


# set ABI by default to 0

Expand Down