Skip to content

[dynamo][torch_np] support linalg, random and fft module #105320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[dynamo][torch_np] support linalg, random and fft module #105320

wants to merge 11 commits into from

Conversation

kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Jul 17, 2023 •
edited
Loading

Support tracing through np.linalg with torch_np installed. Will update with other modules if this approach makes sense.

TODO:

  • Add test for fft and random.

Fixes #105269

cc @mruberry @rgommers @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @aakhundov

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105320

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f9bef7a:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kshitij12345 kshitij12345 changed the title [torch_np] support linalg module [dynamo][torch_np] support linalg module Jul 17, 2023
kshitij12345
kshitij12345 commented Jul 17, 2023
View reviewed changes
kshitij12345
kshitij12345 commented Jul 17, 2023
View reviewed changes
@kshitij12345 kshitij12345 marked this pull request as ready for review July 17, 2023 14:50
@kshitij12345
Copy link
Collaborator Author

cc: @lezcano

lezcano
lezcano reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but let's wait for a proper review from a dynamo maintainer.

@lezcano lezcano added the module: numpy Related to numpy support, and also numpy compatibility of our operators label Jul 17, 2023
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 17, 2023
@kshitij12345 kshitij12345 changed the title [dynamo][torch_np] support linalg module [dynamo][torch_np] support linalg, random and fft module Jul 18, 2023
kshitij12345
kshitij12345 commented Jul 18, 2023
View reviewed changes
lezcano
lezcano reviewed Jul 18, 2023
View reviewed changes
lezcano
lezcano approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note, otherwise it LGTM.

Thank you!

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 18, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-br ev-br ev-br left review comments

@lezcano lezcano lezcano approved these changes

@ezyang ezyang ezyang approved these changes

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: numpy Related to numpy support, and also numpy compatibility of our operators open source release notes: dynamo triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graph break in compiling np.linalg.norm and other np.linalg functions
8 participants
@kshitij12345 @pytorchmergebot @ezyang @ev-br @lezcano @larryliu0820 @pytorchbot @mikaylagawarecki