Skip to content

Fix TORCH_CHECK macros when glog is used #83216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix TORCH_CHECK macros when glog is used #83216

wants to merge 1 commit into from

Conversation

wconstab
Copy link
Contributor

@wconstab wconstab commented Aug 10, 2022 •
edited
Loading

Makes TORCH_CHECK_* run unconditionally, leaving only TORCH_DCHECK_*
special-cased to be optimized out in release builds.

Fixes a bug in #82032, relating to this comment
#82032 (comment)

@wconstab
Fix TORCH_CHECK macros when glog is used
d0970fa 
Makes TORCH_CHECK_* run unconditionally, leaving only TORCH_DCHECK_*
special-cased to be optimized out in release builds.
@wconstab wconstab requested review from ezyang, datumbox and fmassa August 10, 2022 22:55
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 10, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit d0970fa (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@wconstab wconstab mentioned this pull request Aug 10, 2022
Closed
datumbox
datumbox approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wconstab
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @wconstab.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 11, 2022
@wconstab @facebook-github-bot
Fix TORCH_CHECK macros when glog is used (#83216) (#83216)
d1774dd 
Summary:
Makes TORCH_CHECK_* run unconditionally, leaving only TORCH_DCHECK_*
special-cased to be optimized out in release builds.

Fixes a bug in #82032, relating to this comment
#82032 (comment)

Pull Request resolved: #83216
Approved by: https://github.com/ezyang, https://github.com/datumbox

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/abb2204f6a9c5af4e14e11cc69de8bcb5cceaea0

Reviewed By: seemethere

Differential Revision: D38624296

Pulled By: wconstab

fbshipit-source-id: 23f8db4b3cad7ba9d2105a33b0d40736326f7c4a
@github-actions github-actions bot deleted the wconstab/fix_check branch February 19, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@datumbox datumbox datumbox approved these changes

@fmassa fmassa Awaiting requested review from fmassa

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wconstab @facebook-github-bot @pytorchmergebot @ezyang @datumbox