Skip to content

[BugFix] correct dim for resolving dtype in _split_and_pad_sequence #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[BugFix] correct dim for resolving dtype in _split_and_pad_sequence #2801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion torchrl/objectives/value/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,9 @@ def _split_and_pad_sequence(

# int16 supports length up to 32767
dtype = (
torch.int16 if tensor.shape[-2] < torch.iinfo(torch.int16).max else torch.int32
torch.int16
if tensor.size(time_dim) < torch.iinfo(torch.int16).max
else torch.int32
)
arange = torch.arange(max_seq_len, device=tensor.device, dtype=dtype).unsqueeze(0)
mask = arange < splits.unsqueeze(1)
Expand Down