Skip to content

Update test_generate_binary_build_matrix.py reference files after #5986 #5993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

clee2000
Copy link
Contributor

Also adds a way to update the files by just running the test script through python -m tools.tests.test_generate_binary_build_matrix --update-reference-files

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 7:43pm

@clee2000 clee2000 requested a review from atalman November 27, 2024 19:33
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2024
@clee2000 clee2000 marked this pull request as ready for review November 27, 2024 19:33
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 404c4ea into main Nov 27, 2024
6 checks passed
@atalman atalman deleted the csl/update_test_binary_build_matrix_ref_files branch November 27, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants