Unify use of 'output' and 'desired' in audio code-base #697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames a few stuff in our C++ code. (This isn't about Python code or Python conventions!)
I've been a bit slopy with the use of the
desired
andoutput
prefixes in the audio C++ code, and this is becoming more evident as I'm working now on sample rate conversions (PR to come). I want to establish a clearer convention for the C++ audio code:desiredNumChannels
. In C++ we should just represent this as fields in AudioStreamOptions (will create follow-up PR). It usually is anstd::optional
. When these fields are inAudioStreamOptions
(as they should and will), we can ommit thedesired
prefix.outputStuff
is never anstd::optional
and it is typically set todesiredStuff.value_or(value_of_the_source)
.