2/n Replace Input Generation + Documentation #2875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72798357 |
aporialiao
force-pushed
the
export-D72798357
branch
from
4c38b22 to
e3ef437
Compare
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Apr 10, 2025
Summary: * Using refactored `ModelInput` generation from D71556886 for dynamic sharding unit test. This will be important for CW sharding since existing input generation call here is insufficient for handling multiple shards per table. * Add additional docs explaining uses for some Dynamic Sharding API * Rename ModelInput kjt creation method to indicate static use outside of ModelInput class Reviewed By: TroyGarden Differential Revision: D72798357
|
This pull request was exported from Phabricator. Differential Revision: D72798357 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Apr 10, 2025
Summary: * Using refactored `ModelInput` generation from D71556886 for dynamic sharding unit test. This will be important for CW sharding since existing input generation call here is insufficient for handling multiple shards per table. * Add additional docs explaining uses for some Dynamic Sharding API * Rename ModelInput kjt creation method to indicate static use outside of ModelInput class Reviewed By: TroyGarden Differential Revision: D72798357
aporialiao
force-pushed
the
export-D72798357
branch
from
e3ef437 to
35523bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72798357 |
Summary: Pull Request resolved: pytorch#2875 * Using refactored `ModelInput` generation from D71556886 for dynamic sharding unit test. This will be important for CW sharding since existing input generation call here is insufficient for handling multiple shards per table. * Add additional docs explaining uses for some Dynamic Sharding API * Rename ModelInput kjt creation method to indicate static use outside of ModelInput class Reviewed By: TroyGarden Differential Revision: D72798357
aporialiao
force-pushed
the
export-D72798357
branch
from
35523bf to
2644044
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72798357 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Apr 10, 2025
Summary: * Using refactored `ModelInput` generation from D71556886 for dynamic sharding unit test. This will be important for CW sharding since existing input generation call here is insufficient for handling multiple shards per table. * Add additional docs explaining uses for some Dynamic Sharding API * Rename ModelInput kjt creation method to indicate static use outside of ModelInput class Reviewed By: TroyGarden Differential Revision: D72798357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Using refactored
ModelInputgeneration from D71556886 for dynamic sharding unit test. This will be important for CW sharding since existing input generation call here is insufficient for handling multiple shards per table.Add additional docs explaining uses for some Dynamic Sharding API
Rename ModelInput kjt creation method to indicate static use outside of ModelInput class
Reviewed By: TroyGarden
Differential Revision: D72798357