Fix - Port TorchRL Pendulum tutorial from pytorch.org/rl to pytorch.org/tutorials #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2653
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6c025c6 with merge base a668406 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
rl
|
Quick question @svekars, Can you please let me know where the static images need to be placed?. |
|
You can put under |
svekars
reviewed
Nov 6, 2023
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
Co-authored-by: Svetlana Karslioglu <[email protected]>
|
please maker sure to fix the spellcheck |
vmoens
approved these changes
Nov 8, 2023
|
Still need to fix spellcheck and resolve the merge conflict. Otherwise, looks good. |
svekars
reviewed
Nov 8, 2023
svekars
reviewed
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2352
Description
Initial changes made to port https://github.com/pytorch/rl/blob/main/tutorials/sphinx-tutorials/pendulum.py
cc @vmoens @nairbv @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen