Skip to content

Update export tutorial #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 21, 2024
Merged

Update export tutorial #2806

merged 6 commits into from
Mar 21, 2024

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented Mar 20, 2024 •
edited
Loading

Fixes #2805

Description

  • Changed functions passed to export to nn.Module
  • Changed calling conventions of exported_program to exported_program.module()
  • Removed mentions of equality constraints
  • Added pointer to official torch.export docs
  • Updated custom op meta implementations
  • Added section on how to run exported program with inductor/tensorrt backends cc @chauhang

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2806

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ed9248f with merge base 361c4c7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@angelayi angelayi requested review from zhxchen17 and svekars March 20, 2024 00:35
@svekars svekars changed the base branch from main to 2.3-RC-TEST March 20, 2024 15:58
svekars
svekars reviewed Mar 20, 2024
View reviewed changes
@svekars svekars added the 2.3 label Mar 20, 2024
svekars
svekars reviewed Mar 20, 2024
View reviewed changes
svekars
svekars reviewed Mar 20, 2024
View reviewed changes
@svekars
Update intermediate_source/torch_export_tutorial.py
809b617 
Small change to re-kick the build.
svekars
svekars reviewed Mar 21, 2024
View reviewed changes
@svekars svekars merged commit 19f34fa into 2.3-RC-TEST Mar 21, 2024
@svekars svekars deleted the angelayi/export2 branch March 21, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars approved these changes

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

Assignees
No one assigned
Labels
2.3 cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - intermediate_source/torch_export_tutorial.py fails against 2.3 RC binaries
3 participants
@angelayi @svekars @facebook-github-bot