Skip to content

[Tensor Parallel] update tutorial to simplify embedding + first transformer block #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2024

Conversation

tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented May 16, 2024

Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2871

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a4cd3e5 with merge base 9e1f001 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

tianyu-l added a commit that referenced this pull request May 16, 2024
…former block

ghstack-source-id: ddc4f77
Pull Request resolved: #2871
@tianyu-l tianyu-l requested a review from wanchaol May 16, 2024 01:38
tianyu-l added a commit to pytorch/examples that referenced this pull request May 16, 2024
…first transformer block"


Following changes in pytorch/torchtitan#314, to apply a reduce-scatter instead of the more expensive all-reduce + local chunk.

cross PR with pytorch/tutorials#2871

[ghstack-poisoned]
…first transformer block"


cross PR with pytorch/examples#1259


[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request May 16, 2024
…former block

ghstack-source-id: 4465209
Pull Request resolved: #2871
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for updating!

@tianyu-l tianyu-l merged commit a4cd3e5 into gh/tianyu-l/1/base May 16, 2024
19 checks passed
@tianyu-l
Copy link
Contributor Author

It seems the merging failed since I don't have required access. Creating an identical PR #2872 to be merged by @svekars

@svekars
Copy link
Contributor

svekars commented May 16, 2024

Sorry we don't support gh-stack in this repo, I approved #2872 and you should be able to merge.

@svekars svekars deleted the gh/tianyu-l/1/head branch May 17, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants