Fix up custom op tutorials #2873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2873
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f1b1559 with merge base 13e7981 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ydwu4
approved these changes
May 16, 2024
| # - Sometimes, the custom op you are exporting has data-dependent output, meaning | ||
| # we can't determine the shape of the output at compile time. In this case, you can do | ||
| # following: | ||
| @torch.library.register_fake("mylib::op_that_has_data_dependent") |
There was a problem hiding this comment.
Any example is using this fake op op_that_has_data_dependent? Might worth adding one if not.
svekars
reviewed
May 17, 2024
avikchaudhuri
approved these changes
May 17, 2024
svekars
reviewed
May 17, 2024
svekars
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER
Description
Checklist