Skip to content

[doc][c10d] Fixes to FSDP tutorial #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

[doc][c10d] Fixes to FSDP tutorial #3138

merged 2 commits into from
Oct 31, 2024

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Oct 31, 2024 •
edited by pytorch-bot bot
Loading

Summary:
Fix up the actual FSDP tutorial to get it running again.

Description

Fix up the actual referred to example here:
https://github.com/pytorch/examples/pull/1297/files

In addition to this, some minor fix ups in this document.

  1. Fix typo in link adavnced -> advanced.
  2. Add a grid card with pre-requisites and what you will learn.
  3. Add more links to actual FSDP paper.
  4. Stop referring to PyTorch nightly, instead just tell reader to get latest PyTorch as FSDP has been released for a while.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @wconstab @osalpekar @H-Huang @kwen2501

@c-p-i-o
[doc][c10d] Fixes to FSDP tutorial
70dc763 
Summary:
Fix up the actual FSDP tutorial to get it running again.
https://github.com/pytorch/examples/pull/1297/files
This tutorial is refered to in this document.

In addition to this, minor fixups in this document.
1. Fix typo in link.
2. Add a grid card with pre-requisites and what you will learn.
3. Add more links to actual FSDP paper.
4. Stop refering to PyTorch nightly, instead just tell reader to get
   latest PyTorch as FSDP has been released for a while.

Test Plan:
Render and examine.

Reviewers:

Subscribers:

Tasks:

Tags:
@c-p-i-o c-p-i-o requested review from svekars and wz337 October 31, 2024 17:23
@c-p-i-o c-p-i-o self-assigned this Oct 31, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 31, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3138

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 05f8e0c with merge base 60e29a0 (image):

NEW FAILURE - The following job has failed:

  • link check on PR / linkChecker (gh)
    * [404] [https://pytorch.org/tutorials/intermediate/FSDP_advanced_tutorial.html?utm_source=distr_landing&utm_medium=FSDP_advanced](https://pytorch.org/tutorials/intermediate/FSDP_advanced_tutorial.html?utm_source=distr_landing&utm_medium=FSDP_advanced) | Failed: Network error: Not Found

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@c-p-i-o c-p-i-o merged commit 4e9296e into main Oct 31, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars approved these changes

@wz337 wz337 Awaiting requested review from wz337

Assignees

@c-p-i-o c-p-i-o

Labels
cla signed distributed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-p-i-o @svekars @facebook-github-bot