-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[ONNX] Update API to torch.onnx.export(..., dynamo=True) #3223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3223
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit bfad889 with merge base 469d95b ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@svekars PTAL |
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
I don’t see print outputs here either https://pytorch.org/tutorials/beginner/onnx/intro_onnx.html. Do we need to do something to enable it? (If there is an option) |
They have prints here https://pytorch.org/tutorials/intermediate/torchrec_intro_tutorial.html |
Yeah, I don't know. I tried a local build, and registry has the print out while control flow does not. |
@svekars Should we skip link checker on this PR, since it's newly added page? Or is there anything I missed to enable the link? |
@svekars bump |
skip-linkcheck because the failing link will become live after PR is merged. |
@svekars Sorry, could you approve the workflows again? I missed the misspelled words. Could you also point me to the local repro of misspelled word checks? Thank you! |
|
beginner_source/onnx/export_control_flow_model_to_onnx_tutorial.py
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,185 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to add a customcard for this tutorial in index.rst (like this) so it's discoverable on the landing page under the ONNX selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can you submit a follow up for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do it as a follow up.
@svekars Thanks for helping me on this PR! I set up the exact same bash script test for pyspelling locally, and it gave me the same error as the one on CI when I run it on main branch with ONNX pages. Do you recommend us just remove toctree? Is there another preferrable way to keep the functionality of showing related pages to user in the bottom of the current tutorial page? Thanks! |
Can you point me to the error? Spellcheck can be ignored for now. |
It's under pyspelling CI test.
|
Can ignore spellcheck for now. |
Fixes #3200
Description
Checklist
TODO: The registry doc also needs an update.
cc @justinchuby