Check target boxes input on generalized_rcnn.py #2207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2192 with minimal changes, but I can add checks to the
labels
andscores
fields too. I would also like your opinion on creating a function to make these checks because they can get quite verbose (especially if we check the other fields as well).Additionally, if we want full validation of the model-specific fields (e.g.
masks
for Mask R-CNN) we need to specify a check function for each child, perhaps by overriding a_check
method or passing it to the__init__
method.