Skip to content

Skip big model in test to reduce memory usage in CI #5903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 28, 2022

Conversation

YosuaMichael
Copy link
Contributor

@YosuaMichael YosuaMichael commented Apr 27, 2022

Seems like the CI getting flaky caused by OOM when testing big model (sample)

This PR aim to enable skipping the test for chosen big models (for example vit_h_14).

cc @datumbox

…rectly instead of function param to reduce changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YosuaMichael. It looks good, just 2 minor comments for your attention.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, we can merge if the CI is green.

@datumbox datumbox merged commit e0467c6 into pytorch:main Apr 28, 2022
facebook-github-bot pushed a commit that referenced this pull request May 6, 2022
Summary:
* Skip big model in test

* Let get_models_from_module func to read skipped_models from global directly instead of function param to reduce changes

* Also skip regnet_y_128gf

* Only skip test for test_classification_model and create toggle using env var

* Remove unnecessary comment

* Fix comparison of device to use str

* Add logic to test_classification_model directly

* Add kprcnn in autocast flaky list

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095702

fbshipit-source-id: fb8d656aba08e001da48a0cf7ec7b9178290819d

Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants