Skip big model in test to reduce memory usage in CI #5903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly instead of function param to reduce changes
datumbox
reviewed
Apr 27, 2022
datumbox
reviewed
Apr 27, 2022
There was a problem hiding this comment.
Thanks @YosuaMichael. It looks good, just 2 minor comments for your attention.
YosuaMichael
commented
Apr 27, 2022
datumbox
approved these changes
Apr 28, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
May 6, 2022
Summary: * Skip big model in test * Let get_models_from_module func to read skipped_models from global directly instead of function param to reduce changes * Also skip regnet_y_128gf * Only skip test for test_classification_model and create toggle using env var * Remove unnecessary comment * Fix comparison of device to use str * Add logic to test_classification_model directly * Add kprcnn in autocast flaky list Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095702 fbshipit-source-id: fb8d656aba08e001da48a0cf7ec7b9178290819d Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the CI getting flaky caused by OOM when testing big model (sample)
This PR aim to enable skipping the test for chosen big models (for example vit_h_14).
cc @datumbox