Skip to content

Add missing _version to the MLPBlock #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented May 31, 2022

Adds missing _version on the MLPBlock. The code doesn't break without it but we shouldn't execute the for loop unnecessarily.

Copy link
Contributor

@YosuaMichael YosuaMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@datumbox datumbox merged commit ba4b0db into pytorch:main May 31, 2022
@datumbox datumbox deleted the models/version_mlpblock branch May 31, 2022 10:12
facebook-github-bot pushed a commit that referenced this pull request Jun 6, 2022
Summary:
* Add missing `_version` to the MLPBlock

* fix linter

Reviewed By: NicolasHug

Differential Revision: D36931838

fbshipit-source-id: f1871bca9aa4b2fb9fb9eb1a1a2c60f46f5fe674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants