Moved pfm file reading into dataset utils #6270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Jul 14, 2022
There was a problem hiding this comment.
Thanks @TeodorPoncu , LGTM. The only important comment I have is to keep it private as suggested below
torchvision/datasets/utils.py
Outdated
| @@ -483,3 +484,39 @@ def verify_str_arg( | |||
| raise ValueError(msg) | |||
|
|
|||
| return value | |||
|
|
|||
|
|
|||
| def read_pfm(file_name: str, slice_channels: int = 2) -> np.ndarray: | |||
There was a problem hiding this comment.
Let's keep it private, we don't really need to expose it to users
Suggested change
| def read_pfm(file_name: str, slice_channels: int = 2) -> np.ndarray: | |
| def _read_pfm(file_name: str, slice_channels: int = 2) -> np.ndarray: |
torchvision/datasets/utils.py
Outdated
|
|
||
|
|
||
| def read_pfm(file_name: str, slice_channels: int = 2) -> np.ndarray: | ||
| """Read file in .pfm format. Might contain |
There was a problem hiding this comment.
Looks like this sentence is unfinished?
torchvision/datasets/utils.py
Outdated
| Args: | ||
| file_name (str): Path to the file. | ||
| slice_channels (int): Number of channels to slice out of the file. | ||
| Useful for reading different data formats stored in .pfm files: Optical Flows, Stereo Disparity Maps, etc. |
There was a problem hiding this comment.
Skipping a line in a parameter description requires to indent it to the right (otherwise sphinx doesn't render it properly):
Suggested change
| Useful for reading different data formats stored in .pfm files: Optical Flows, Stereo Disparity Maps, etc. | |
| Useful for reading different data formats stored in .pfm files: Optical Flows, Stereo Disparity Maps, etc. |
NicolasHug
approved these changes
Jul 14, 2022
|
Hey @TeodorPoncu! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
Summary: * Moved pfm file reading into dataset utils * Made _read_pfm private. Fixed doc format issues. Reviewed By: jdsgomes Differential Revision: D37993417 fbshipit-source-id: 15d10ac7dc6a22397ba317b7d7728ba707e812a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6259 functionality redefinition both in _optical_flow.py and _stereo_matching.py datasets.