Skip to content

cleanup for box encoding and decoding in FCOS #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 2, 2022

Conversation

abhi-glitchhg
Copy link
Contributor

@abhi-glitchhg abhi-glitchhg commented Jul 16, 2022

followup pr of #6203 and #6278

@datumbox
Copy link
Contributor

@abhi-glitchhg Thanks for the PR.

Could you please resolve the conflicts?

@abhi-glitchhg abhi-glitchhg marked this pull request as draft July 28, 2022 04:19
@abhi-glitchhg abhi-glitchhg changed the title cleanup for box decoding in FCOS cleanup for box encoding and decoding in FCOS Jul 30, 2022
@abhi-glitchhg abhi-glitchhg marked this pull request as ready for review July 30, 2022 16:43
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit 96fa820 into pytorch:main Aug 2, 2022
facebook-github-bot pushed a commit that referenced this pull request Aug 2, 2022
Summary:
* cleaning up box decoding

* minor nits

* cleanup for box encoding also addded.

Reviewed By: NicolasHug

Differential Revision: D38351758

fbshipit-source-id: 457051a1f5118f96dfacaa58667b61e1b6db73c5
@abhi-glitchhg abhi-glitchhg deleted the cleanup branch August 8, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants