add crestereo implementation #6310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeodorPoncu
changed the title
jdsgomes
reviewed
Aug 11, 2022
jdsgomes
reviewed
Aug 15, 2022
jdsgomes
reviewed
Aug 16, 2022
jdsgomes
reviewed
Aug 16, 2022
|
you also need to add |
jdsgomes
reviewed
Aug 16, 2022
… into add-crestereo-model
jdsgomes
changed the title
YosuaMichael
reviewed
Sep 8, 2022
There was a problem hiding this comment.
Nice work @TeodorPoncu ! Overall it looks pretty good. I have several comments that mostly NIT.
There was a problem hiding this comment.
Hi @TeodorPoncu, overall looks good, I just have a few more comments
There was a problem hiding this comment.
Hi @TeodorPoncu, I think this is very close to a merge. Just have few things left that you forgot to update and NITs.
|
@TeodorPoncu Oh ya, also please resolve the conflict on the test files |
YosuaMichael
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Thanks for your hard work @TeodorPoncu !
The PR looks good to me!
@jdsgomes could you give a one more pass of review as well? Thanks!
jdsgomes
approved these changes
Sep 14, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
Summary: * crestereo draft implementation * minor model fixes. positional embedding changes. * aligned base configuration with paper * Adressing comments * Broke down Adaptive Correlation Layer. Adressed some other commets. * adressed some nits * changed search size, added output channels to model attrs * changed weights naming * changed from iterations to num_iters * removed _make_coords, adressed comments * fixed jit test * config nit * Changed device arg to str Reviewed By: jdsgomes Differential Revision: D39543279 fbshipit-source-id: c6101958588eb43201f92ff4f687bd32cbbcbbd1 Co-authored-by: Joao Gomes <[email protected]> Co-authored-by: YosuaMichael <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft version for the CREStereo model implementation.
It's over-commented for easier readability for those that are unfamiliar with the paper.
It also makes use of ModuleDicts and Dicts to process / access feature pyramid level instead of ModuleLists and Lists for readability purposes.