Skip to content

Fixed issue with F.crop when cropping outside the input image #6615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2022
Merged

Fixed issue with F.crop when cropping outside the input image #6615

merged 2 commits into from
Sep 21, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 20, 2022

Fixes #6613

@vfdev-5 vfdev-5 mentioned this pull request Sep 20, 2022
Merged
@datumbox
Copy link
Contributor

@vfdev-5 Something made the mypy go wild with errors. Could you have a look?

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Sep 20, 2022

Philip already reported that, related to torchdata: pytorch/data#780 (comment)

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Sep 20, 2022

@datumbox can we merge this PR ?

datumbox
datumbox approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox
Copy link
Contributor

@vfdev-5 Yes you can merge it. I understand the issue is caused by an upstream dependency on TorchData and should be fixed.

@datumbox datumbox merged commit a188bcd into pytorch:main Sep 21, 2022
@vfdev-5 vfdev-5 deleted the fix-6613-crop-outside branch September 21, 2022 08:43
facebook-github-bot pushed a commit that referenced this pull request Sep 23, 2022
@jdsgomes @facebook-github-bot
[fbsync] Fixed issue with F.crop when cropping outside the input image (
fedc8c1 
#6615)

Summary: Co-authored-by: Vasilis Vryniotis <[email protected]>

Reviewed By: NicolasHug

Differential Revision: D39765309

fbshipit-source-id: 57b2908b5647b85434d3b9892c9939c522af9cb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
bug cla signed module: transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F.crop behavior diverges between tensor and PIL images
3 participants
@vfdev-5 @datumbox @facebook-github-bot