Skip to content

Update tf submodule to 04/07/2022 #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Update tf submodule to 04/07/2022 #3507

merged 2 commits into from
Apr 21, 2022

Conversation

JackCaoG
Copy link
Collaborator

No description provided.

@JackCaoG JackCaoG requested a review from miladm April 16, 2022 00:25
@JackCaoG
Copy link
Collaborator Author

I verified that resnet worked on TPUVM with this new tf update.

TODO: verify optimization_barrier still works with the patch

@JackCaoG
Copy link
Collaborator Author

so there is a bug in the bazel, when I have a cache for tf build, rebuilding with this new commit will fail with message like

ERROR: /usr/local/google/home/jackcao/.cache/bazel/_bazel_jackcao/f24f9e5588a9a14d59c86f3aad6558a2/external/llvm-project/mlir/BUILD.bazel:2992:11: Compiling mlir/lib/Support/IndentedOstream.cpp failed: undeclared inclusion(s) in rule '@llvm-project//mlir:Support':
this rule is missing dependency declarations for the following files included by 'mlir/lib/Support/IndentedOstream.cpp':
  'bazel-out/k8-opt-exec-50AE0418/bin/external/llvm-project/llvm/config.cppmap'
  'bazel-out/k8-opt-exec-50AE0418/bin/external/llvm-project/llvm/Demangle.cppmap'
  'bazel-out/k8-opt-exec-50AE0418/bin/external/llvm_terminfo/terminfo.cppmap'
  'bazel-out/k8-opt-exec-50AE0418/bin/external/llvm_zlib/zlib.cppmap'
Target //tensorflow/compiler/xla/xla_client:libxla_computation_client.so failed to build
Use --verbose_failures to see the command lines of failed build steps.

I have tried to clean the bazel cache by manually deleting ~/.cache/bazel and bazel clean --expunge under tf dir. Both of them does not do the trick. If I create a new VM and build from scratch, build will pass. Circle CI build also pass. I am a bit running out of ideas. I felt like there is some kind of cache still remain after all of the cleanup I do.

@JackCaoG
Copy link
Collaborator Author

@yeounoh in case you has more knowledge about how bazel works than I do.

Copy link
Contributor

@yeounoh yeounoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- also tested on 1VM to run with a new libtpu.

@JackCaoG
Copy link
Collaborator Author

@hjm-aws FYI

@JackCaoG JackCaoG merged commit 1d0a6e7 into master Apr 21, 2022
@JackCaoG JackCaoG deleted the new_tf_04152022 branch April 21, 2022 23:13
JackCaoG added a commit that referenced this pull request Apr 22, 2022
JackCaoG added a commit that referenced this pull request Apr 22, 2022
JackCaoG added a commit that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants