Respect default dtype #3798
Merged
Respect default dtype #3798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the linked PR, the python API never actually passed nullopt and so the `OrFloat` path was never tested.
|
@JackCaoG ping |
|
@peterbell10 Test seems to be passing, I guess I can directly merge this pr? |
|
Yes this change makes sense on its own. I was only using the pin to test that it fixed the xla problems in the main pytorch PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to pytorch/pytorch#82241, the python API never actually passed nullopt
and so the
OrFloatpath was never tested.