Revert of #3822 "Revert "implementing sym_numel_custom"" #3826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd1c38b.
Krovatkin
force-pushed
the
krovatkin/numel2
branch
from
9790391 to
a75c0a3
Compare
Krovatkin
changed the title
miladm
requested changes
Aug 4, 2022
| @@ -35,6 +35,7 @@ class XLATensorImpl : public c10::TensorImpl { | |||
| at::IntArrayRef sizes_custom() const override; | |||
| c10::SymIntArrayRef sym_sizes() const override; | |||
| c10::SymIntArrayRef sym_sizes_custom() const override; | |||
| c10::SymInt sym_numel_custom() const override; | |||
There was a problem hiding this comment.
seems to be breaking build. do you need the override here?
Krovatkin
force-pushed
the
krovatkin/numel2
branch
from
a75c0a3 to
045c9e5
Compare
miladm
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
LGTM. Thanks @Krovatkin - pending pin removal and test passing.
Krovatkin
added a commit
that referenced
this pull request
Aug 4, 2022
…)" This reverts commit ce6b404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue in the pytorch PR.