-
Notifications
You must be signed in to change notification settings - Fork 524
Use tfrt cpu client #3898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tfrt cpu client #3898
Conversation
darisoy
commented
Aug 16, 2022
- Add the CPU_ASYNC_CLIENT env var
- Change PjRtComputationClient to use GetTfrtCpuClient when testing multiple processes with a CPU
- Add unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
error seems real
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collectives hang forever on CPU with multiple devices. This test passed before because we ignored CPU_NUM_DEVICES
. @darisoy is investigating if there is an easy fix. Otherwise, we can implement a workaround to go back to testing on one CPU device.
46192a1
to
9f09c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!