Revert "Add libtpu configuration to cpp test script" #3970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3957
I am going to revert this change to unblock TPUVM wheel build. This pr itself fixed the CPP test issue on libtpu. However due to an known issue in libtpu, the build will fail with
For some reason our wheel build will trigger the cpp test(with the xla:CPU I believe). With this change, the TPUVM build will try to load the libtpu and hence fail the whole build. I think we should check both
XRT_TPU_CONFIG
orPJRT_DEVICE == TPU
before loading libtpu in cpp test. Running a cpp test using xla:CPU sounds weird when publishing a tpu wheel, we should use XLA:TPU.