Skip to content

Revert "Add libtpu configuration to cpp test script" #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Sep 5, 2022

Reverts #3957

I am going to revert this change to unblock TPUVM wheel build. This pr itself fixed the CPP test issue on libtpu. However due to an known issue in libtpu, the build will fail with

Step #2: Failed to get worker list with error: Failed to fetch URL (http status: 404) No errorF0904 10:21:33.187127      33 enforce_kernel_ipv6_support.cc:72] Check failed: loopback6_ok || !loopback4_ok This machine (fc0bad92a47e) does not have an IPv6 loopback (::1) interface.  This configuration is obsolete.  You may temporarily set --enforce_kernel_ipv6_support=false to bypass this check, but code elsewhere in g3      may fail as result.  See gl_________________30/topics/localhost for details.
Step #2: *** Check failure stack trace: ***
Step #2:     @     0x7fadb4b71164  (unknown)

For some reason our wheel build will trigger the cpp test(with the xla:CPU I believe). With this change, the TPUVM build will try to load the libtpu and hence fail the whole build. I think we should check both XRT_TPU_CONFIG or PJRT_DEVICE == TPU before loading libtpu in cpp test. Running a cpp test using xla:CPU sounds weird when publishing a tpu wheel, we should use XLA:TPU.

@JackCaoG
Copy link
Collaborator Author

JackCaoG commented Sep 5, 2022

I am going to force merge this pr to unblock the tpuvm wheel build.

@JackCaoG JackCaoG merged commit b8688ee into master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant