Manually register einsum on xla #8801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgmoka
force-pushed
the
xla_einsum_registration
branch
from
a5b3f15 to
4cab4ed
Compare
pgmoka
changed the title
|
@ysiraichi You mentioned in #8787 using the XLA counters. I am not familiar with this. Could you send me a resource, or an example of its usage? |
|
I am looking into the error here. I will also be looking at checking that there are no re-shapes on tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do manual registration of XLANativeFunctions::einsum for XLA.
This is necessary because currently PyTorch overwrites the key AutogradXLA registration with a its XLA key registration. While ideally we would be able to resolve this problem, this work around resolves the issue from our end. It is also not possible to use full code generation due to #8739.
This manual registration relies on the
XLANativeFunctions::einsumfunction fromxla/torch_xla/csrc/aten_xla_type.cpp.Originally being worked on #8787. Abandoned due to conflicts being complex enough starting a new PR made more sense.