Skip to content

fix runner cancel issue #9011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/_build_plugin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,19 @@ on:
type: string
description: Runner type for the test
default: linux.12xlarge

timeout-minutes:
required: false
type: number
description: Timeout in minutes for the build job
default: 120
secrets:
gcloud-service-key:
required: true
description: Secret to access Bazel build cache
jobs:
build:
runs-on: ${{ inputs.runner }}
timeout-minutes: ${{ inputs.timeout-minutes }}
container:
image: ${{ inputs.dev-image }}
env:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/_build_torch_with_cuda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ on:
type: string
description: Runner type for the test
default: linux.12xlarge
timeout-minutes:
required: false
type: number
description: Timeout in minutes for the build job
default: 120
jobs:
build:
runs-on: ${{ inputs.runner }}
timeout-minutes: ${{ inputs.timeout-minutes }}
container:
image: ${{ inputs.dev-image }}
env:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/_build_torch_xla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,19 @@ on:
type: string
description: Runner type for the test
default: linux.12xlarge

timeout-minutes:
required: false
type: number
description: Timeout in minutes for the build job
default: 120
secrets:
gcloud-service-key:
required: true
description: Secret to access Bazel build cache
jobs:
build:
runs-on: ${{ inputs.runner }}
timeout-minutes: ${{ inputs.timeout-minutes }}
container:
image: ${{ inputs.dev-image }}
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
required: true
jobs:
build-docs:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 45
container:
image: ${{ inputs.dev-image }}
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/_tpu_ci.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
name: TPU Integration Test
on:
workflow_call:
inputs:
timeout-minutes:
required: false
type: number
description: Timeout in minutes for the job run
default: 120
jobs:
tpu-test:
runs-on: v4-runner-set
timeout-minutes: ${{ inputs.timeout-minutes }}
steps:
- name: Checkout actions
uses: actions/checkout@v4
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ concurrency:
jobs:

get-torch-commit:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
outputs:
torch_commit: ${{ steps.commit.outputs.torch_commit }}
steps:
Expand All @@ -33,6 +33,7 @@ jobs:
with:
dev-image: us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/development:3.10_tpuvm
torch-commit: ${{needs.get-torch-commit.outputs.torch_commit}}
timeout-minutes: 240
secrets:
gcloud-service-key: ${{ secrets.GCLOUD_SERVICE_KEY }}

Expand All @@ -47,6 +48,7 @@ jobs:
torch-commit: ${{needs.get-torch-commit.outputs.torch_commit}}
# note that to build a torch wheel with CUDA enabled, we do not need a GPU runner.
runner: linux.24xlarge
timeout-minutes: 120

build-cuda-plugin:
name: "Build XLA CUDA plugin"
Expand Down Expand Up @@ -97,6 +99,8 @@ jobs:
name: "TPU tests"
uses: ./.github/workflows/_tpu_ci.yml
needs: build-torch-xla
with:
timeout-minutes: 300
if: github.event_name == 'push' || github.event_name == 'pull_request'

push-docs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lintercheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
linter_check:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout repo
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/openxla_pin_update_weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
update_and_create_pr:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/torchax.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ concurrency:

jobs:
torchax-cpu:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
strategy:
matrix:
python-version: ['3.10']
Expand Down