-
Notifications
You must be signed in to change notification settings - Fork 68
Adds supports for SBPLX optimizer from nlopt #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0682b92
Add SBPLX to nloptimizer.py
cpossel f5f19d6
Add SBPLX to NLopt
cpossel 648c857
Update .pylintdict
cpossel b9eb614
Complete adding SBPLX
cpossel 9eb3453
Add SBPLX test
cpossel 2f7ca02
Update documentation for SBPLX
cpossel 9f122ca
Add release note for SBPLX
cpossel 6f14652
Update releasenote (fix url)
cpossel 925fea6
Update qiskit_algorithms/optimizers/__init__.py
cpossel d741480
Update .pylintdict
cpossel 2b8f45f
Update releasenotes/notes/sbplx_optimizer-a27361fc4ac8de8c.yaml
woodsp-ibm fc40c37
Update releasenotes/notes/sbplx_optimizer-a27361fc4ac8de8c.yaml
woodsp-ibm a43f557
Update releasenotes/notes/sbplx_optimizer-a27361fc4ac8de8c.yaml
woodsp-ibm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# This code is part of a Qiskit project. | ||
# | ||
# (C) Copyright IBM 2025. | ||
# | ||
# This code is licensed under the Apache License, Version 2.0. You may | ||
# obtain a copy of this license in the LICENSE.txt file in the root directory | ||
# of this source tree or at http://www.apache.org/licenses/LICENSE-2.0. | ||
# | ||
# Any modifications or derivative works of this code must retain this | ||
# copyright notice, and modified files need to carry a notice indicating | ||
# that they have been altered from the originals. | ||
|
||
"""Sbplx (Subplex) optimizer.""" | ||
|
||
from .nloptimizer import NLoptOptimizer, NLoptOptimizerType | ||
|
||
|
||
class SBPLX(NLoptOptimizer): | ||
""" | ||
Subplex optimizer. | ||
|
||
"Subplex (a variant of Nelder-Mead that uses Nelder-Mead on a sequence of subspaces) | ||
is claimed to be much more efficient and robust than the original Nelder-Mead, | ||
while retaining the latter's facility with discontinuous objectives, | ||
and in my experience these claims seem to be true in many cases. | ||
(However, I'm not aware of any proof that Subplex is globally convergent, | ||
and perhaps it may fail for some objectives like Nelder-Mead; YMMV.)" | ||
Description by Steven G. Johnson, author of NLopt library. | ||
|
||
NLopt local optimizer, derivative-free. | ||
For further detail, please refer to | ||
https://nlopt.readthedocs.io/en/latest/NLopt_Algorithms/#sbplx-based-on-subplex | ||
""" | ||
|
||
def get_nlopt_optimizer(self) -> NLoptOptimizerType: | ||
"""Return NLopt optimizer type.""" | ||
return NLoptOptimizerType.LN_SBPLX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
features: | ||
- | | ||
Support for SBPLX optimizer from NLopt library has been added. | ||
SBPLX is a local gradient-free optimizer based on Nelder-Mead and | ||
is expected to show better convergence behavior. | ||
Further information about this and all other optimizers can be found | ||
`in the API ref. here <https://qiskit-community.github.io/qiskit-algorithms/apidocs/qiskit_algorithms.optimizers.html>__`. | ||
woodsp-ibm marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.