Skip to content

PauliStringPhasor should be a Gate #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dabacon opened this issue Apr 24, 2019 · 1 comment · Fixed by #4696
Closed

PauliStringPhasor should be a Gate #1561

dabacon opened this issue Apr 24, 2019 · 1 comment · Fixed by #4696
Labels
area/gates area/paulis kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@dabacon
Copy link
Collaborator

dabacon commented Apr 24, 2019

Certainly the concept of a gate that does this operation is well defined. Having it around as an object may not be super valuable, except that I really do think having the concept of a gate is very useful for defining what is supported by a device. So now if we have QC that support this phasor we cannot say whether it is supported or not without talking about what qubits it is operating on.
@dabacon
Copy link
Collaborator Author

dabacon commented May 3, 2020

Currently we still have PauliStringGateOperation. It is not at all clear why this is necessary. Certainly PauliStringPhasor is a well defined gate time.

@dabacon dabacon changed the title Question: Why is PauliStringPhasor not a GateOperation? PauliStringPhasor should be a Gate May 3, 2020
@Strilanc Strilanc added kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on labels Sep 22, 2020
@95-martin-orion 95-martin-orion mentioned this issue Nov 17, 2021
Closed
This was referenced Nov 17, 2021
Closed
Merged
CirqBot pushed a commit that referenced this issue Dec 20, 2021
@daxfohl
Implement PauliStringPhasorGate (#4696)
1d8d2f3 
BREAKING CHANGE: PauliStringPhasor no longer inherits from PauliStringGateOperation.

Implements PauliStringPhasor in terms of a GateOperation on a new class PauliStringPhasorGate.

Mostly involved moving existing functions from the operation to the gate, and then having the operation call those methods under the hood.

Closes #1561, xref #4683

@tanujkhattar
MichaelBroughton pushed a commit to MichaelBroughton/Cirq that referenced this issue Jan 22, 2022
@daxfohl @MichaelBroughton
Implement PauliStringPhasorGate (quantumlib#4696)
ce51917 
BREAKING CHANGE: PauliStringPhasor no longer inherits from PauliStringGateOperation.

Implements PauliStringPhasor in terms of a GateOperation on a new class PauliStringPhasorGate.

Mostly involved moving existing functions from the operation to the gate, and then having the operation call those methods under the hood.

Closes quantumlib#1561, xref quantumlib#4683

@tanujkhattar
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@daxfohl @rht
Implement PauliStringPhasorGate (quantumlib#4696)
3a252f5 
BREAKING CHANGE: PauliStringPhasor no longer inherits from PauliStringGateOperation.

Implements PauliStringPhasor in terms of a GateOperation on a new class PauliStringPhasorGate.

Mostly involved moving existing functions from the operation to the gate, and then having the operation call those methods under the hood.

Closes quantumlib#1561, xref quantumlib#4683

@tanujkhattar
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@daxfohl
Implement PauliStringPhasorGate (quantumlib#4696)
c254c81 
BREAKING CHANGE: PauliStringPhasor no longer inherits from PauliStringGateOperation.

Implements PauliStringPhasor in terms of a GateOperation on a new class PauliStringPhasorGate.

Mostly involved moving existing functions from the operation to the gate, and then having the operation call those methods under the hood.

Closes quantumlib#1561, xref quantumlib#4683

@tanujkhattar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/gates area/paulis kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
3 participants
@Strilanc @dabacon @balopat