Skip to content

Use relevant gate info in metrics-to-noise model #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
95-martin-orion opened this issue Mar 11, 2020 · 3 comments
Closed

Use relevant gate info in metrics-to-noise model #2832

95-martin-orion opened this issue Mar 11, 2020 · 3 comments
Assignees
@95-martin-orion
Labels
area/google area/noise kind/task A task that's part of a larger effort

Comments

@95-martin-orion
Copy link
Collaborator

Split off from #2807. This issue specifically tracks improvements in the parameters of noise applied to specific gate types; at the time of writing, all non-measurement gates generate the same DepolarizingChannel regardless of type or duration.
@95-martin-orion 95-martin-orion self-assigned this Mar 11, 2020
@95-martin-orion
Copy link
Collaborator Author

As noted in PR #2715, since the data for this model is Google-specific, we should move it to cirq.google when we get the chance.

@95-martin-orion 95-martin-orion mentioned this issue Apr 21, 2020
Merged
@balopat balopat added this to the 0.9.0 milestone Jul 28, 2020
@95-martin-orion 95-martin-orion removed their assignment Aug 7, 2020
@balopat balopat added area/google kind/task A task that's part of a larger effort area/noise labels Aug 27, 2020
@balopat balopat removed this from the 0.9.0 milestone Sep 16, 2020
@balopat balopat mentioned this issue Feb 17, 2021
Merged
CirqBot pushed a commit that referenced this issue Feb 18, 2021
@balopat
Move google noisemodel to cirq.google (#3824)
f9a82f1 
Moves cirq.google references out of cirq.contrib.noise_model.

- experimental Google noise models -> `cirq/google/experimental`
- other experimental noise models -> `cirq/contrib/noise_models`
- code required by both -> `cirq/devices`

Related to #2832 but motivated by #3737. Also related to the Packaging strategy #3228 - taking contrib apart.
@dstrain115
Copy link
Collaborator

@95-martin-orion Is this bug still useful? If so, can you add more information about it so it can be done by a contributor? Otherwise, let's close it.

@95-martin-orion
Copy link
Collaborator Author

IMO #4640 and related issues and sub-PRs have resolved this. If we want further changes to the metrics-to-noise conversion process, it should be filed under a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@95-martin-orion 95-martin-orion

Labels
area/google area/noise kind/task A task that's part of a larger effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@balopat @MichaelBroughton @mpharrigan @dstrain115 @95-martin-orion