Skip to content

Protocol documentation are missing methods #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dabacon opened this issue May 1, 2020 · 1 comment · Fixed by #3440
Closed

Protocol documentation are missing methods #2953

dabacon opened this issue May 1, 2020 · 1 comment · Fixed by #3440
Labels
area/docs area/docstrings area/protocols area/site triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@dabacon
Copy link
Collaborator

dabacon commented May 1, 2020

Likely because they are private!

It looks like a workaround might be to include

.. automethod:: __magic_method_

in the docstring

@balopat balopat added kind/docs triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on area/site labels Sep 1, 2020
@balopat
Copy link
Contributor

balopat commented Sep 1, 2020

This issue was opened for sphinx - but this is actually still an issue for devsite as well

CirqBot pushed a commit that referenced this issue Oct 23, 2020
Fixes #2953.

Also adds a preview Dockerfile that is a seed for a potential preview service that could run as a GithubAction, deploy an ephemeral Cloud Run container to preview the generated docs and comment on the PR with the link. An example link for this particular change is: https://api-docs-fijpqdu4wa-uc.a.run.app/

While the preview is not "the real thing" - a fullblown devsite preview is not realistic at this point. This preview gives an indication about the intermediate markdown representation generated by tf-docs markdown generator. It's good for:
- latex checking in docstrings - e.g. https://api-docs-fijpqdu4wa-uc.a.run.app/cirq/experiments/two_qubit_state_tomography.md
- checking whether the private methods really show up: https://api-docs-fijpqdu4wa-uc.a.run.app/cirq/protocols/SupportsActOn.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs area/docstrings area/protocols area/site triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants