Skip to content

Implement DeviceMetaData classes #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MichaelBroughton opened this issue Dec 10, 2021 · 2 comments
Closed

Implement DeviceMetaData classes #4743

MichaelBroughton opened this issue Dec 10, 2021 · 2 comments
Assignees
@MichaelBroughton
Labels
area/devices kind/task A task that's part of a larger effort triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@MichaelBroughton
Copy link
Collaborator

Summarize the task
In the roadmapping work done in the devices rework p1 and p2 , there is a plan to implement DeviceMetaData and GridDeviceMetaData. This issue is to track the implementation of these classes as well as the integration of these classes into all existing devices.

Acceptance criteria - when is the task considered done?

  1. Finished Implementation of DeviceMetaData and GridDeviceMetadata.
  2. Implement metadata properties for cirq_google devices.
  3. Deprecate SerializableDevice in cirq_google in favor of returning a regular Device with get_device_from_proto.
  4. Implement metadata properties for all other vendor devices.
@MichaelBroughton MichaelBroughton added the kind/task A task that's part of a larger effort label Dec 10, 2021
@MichaelBroughton MichaelBroughton self-assigned this Dec 10, 2021
@MichaelBroughton MichaelBroughton added the triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on label Dec 10, 2021
@MichaelBroughton MichaelBroughton mentioned this issue Dec 10, 2021
Closed
@MichaelBroughton MichaelBroughton mentioned this issue Jan 13, 2022
Merged
CirqBot pushed a commit that referenced this issue Jan 13, 2022
@MichaelBroughton
Add DeviceMetaData class. (#4832)
3a6ad87 
Adds standalone DeviceMetaData class. First step in #4743 .
This was referenced Jan 14, 2022
Merged
Merged
CirqBot pushed a commit that referenced this issue Jan 14, 2022
@MichaelBroughton
Update equalstester in DeviceMetadata. (#4840)
33a804b 
Part of #4743
CirqBot pushed a commit that referenced this issue Jan 14, 2022
@MichaelBroughton
Add GridDeviceMetadata. (#4839)
ca391ca 
Adds GridDeviceMetadata implementation as part of #4743 .
@MichaelBroughton MichaelBroughton mentioned this issue Jan 21, 2022
Merged
@MichaelBroughton
Copy link
Collaborator Author

cc @verult

CirqBot pushed a commit that referenced this issue Jan 21, 2022
@MichaelBroughton
Add metadata property to device. (#4868)
394b9cf 
Adds metadata property default to None to all devices. I'm going to leave this open to vendors to add to this as they see fit. Part of #4743 . Note that if in the process of deprecating other things for #4744 , I will pull vendor devices onto using metadata to keep behavior working.
@MichaelBroughton MichaelBroughton mentioned this issue Jan 21, 2022
Merged
MichaelBroughton added a commit to MichaelBroughton/Cirq that referenced this issue Jan 22, 2022
@MichaelBroughton
Add DeviceMetaData class. (quantumlib#4832)
5b4a8a5 
Adds standalone DeviceMetaData class. First step in quantumlib#4743 .
MichaelBroughton added a commit to MichaelBroughton/Cirq that referenced this issue Jan 22, 2022
@MichaelBroughton
Update equalstester in DeviceMetadata. (quantumlib#4840)
04fd49c 
Part of quantumlib#4743
MichaelBroughton added a commit to MichaelBroughton/Cirq that referenced this issue Jan 22, 2022
@MichaelBroughton
Add GridDeviceMetadata. (quantumlib#4839)
424d4aa 
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
MichaelBroughton added a commit to MichaelBroughton/Cirq that referenced this issue Jan 22, 2022
@MichaelBroughton
Add metadata property to device. (quantumlib#4868)
ae64988 
Adds metadata property default to None to all devices. I'm going to leave this open to vendors to add to this as they see fit. Part of quantumlib#4743 . Note that if in the process of deprecating other things for quantumlib#4744 , I will pull vendor devices onto using metadata to keep behavior working.
CirqBot pushed a commit that referenced this issue Jan 26, 2022
@MichaelBroughton
Add metadata property for cirq_google devices. (#4869)
12ebe83 
Adds metadata properties to cirq_google devices. Part of  #4743 .


Note for @dstrain115 and @verult : I don't expect these metadata properties to take this exact form forever and that we may end up changing things once we have a more firmed up plan for how DeviceSpec protos and serialization might change.
@MichaelBroughton
Copy link
Collaborator Author

@verult I'm going to Mark this as finished. Since the implementation of MetaData classes are finished and plumbed through cirq_google. The remaining re-works of cirq_google devices falls under your design in flight.

rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@MichaelBroughton @rht
Add DeviceMetaData class. (quantumlib#4832)
6a63eb8 
Adds standalone DeviceMetaData class. First step in quantumlib#4743 .
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@MichaelBroughton @rht
Update equalstester in DeviceMetadata. (quantumlib#4840)
3c30aec 
Part of quantumlib#4743
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@MichaelBroughton @rht
Add GridDeviceMetadata. (quantumlib#4839)
18ba815 
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@MichaelBroughton @rht
Add metadata property to device. (quantumlib#4868)
f365b91 
Adds metadata property default to None to all devices. I'm going to leave this open to vendors to add to this as they see fit. Part of quantumlib#4743 . Note that if in the process of deprecating other things for quantumlib#4744 , I will pull vendor devices onto using metadata to keep behavior working.
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@MichaelBroughton @rht
Add metadata property for cirq_google devices. (quantumlib#4869)
899da42 
Adds metadata properties to cirq_google devices. Part of  quantumlib#4743 .


Note for @dstrain115 and @verult : I don't expect these metadata properties to take this exact form forever and that we may end up changing things once we have a more firmed up plan for how DeviceSpec protos and serialization might change.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@MichaelBroughton
Add DeviceMetaData class. (quantumlib#4832)
8806516 
Adds standalone DeviceMetaData class. First step in quantumlib#4743 .
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@MichaelBroughton
Update equalstester in DeviceMetadata. (quantumlib#4840)
525cff0 
Part of quantumlib#4743
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@MichaelBroughton
Add GridDeviceMetadata. (quantumlib#4839)
59066a5 
Adds GridDeviceMetadata implementation as part of quantumlib#4743 .
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this issue Oct 31, 2024
@MichaelBroughton
Add metadata property to device. (quantumlib#4868)
3b7ab6a 
Adds metadata property default to None to all devices. I'm going to leave this open to vendors to add to this as they see fit. Part of quantumlib#4743 . Note that if in the process of deprecating other things for quantumlib#4744 , I will pull vendor devices onto using metadata to keep behavior working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelBroughton MichaelBroughton

Labels
area/devices kind/task A task that's part of a larger effort triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelBroughton @viathor