Skip to content

Fix inter-dependency of tests in engine_client_test.py #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pavoljuhas opened this issue Sep 9, 2022 · 0 comments · Fixed by #5892
Closed

Fix inter-dependency of tests in engine_client_test.py #5870

pavoljuhas opened this issue Sep 9, 2022 · 0 comments · Fixed by #5892
Labels
kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

When pytest-randomly shuffles unit tests order, engine_client_test.py has several failures which go away when tests are run in unchanged order - https://github.com/quantumlib/Cirq/runs/8261627949.

Cirq version

Cirq 1.1.0.dev at 13890c6 in #5868.
@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Sep 9, 2022
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this issue Sep 9, 2022
@pavoljuhas
Link TODO comment to the associated issue quantumlib#5870
34dbb44
@pavoljuhas pavoljuhas mentioned this issue Sep 27, 2022
Merged
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this issue Sep 27, 2022
@pavoljuhas
Avoid clashing test mocks of QuantumEngineServiceClient
1f754e1 
Restrict mocking to the relevant test module only.

Fixes quantumlib#5870.
CirqBot pushed a commit that referenced this issue Sep 27, 2022
@pavoljuhas
untangle entangled tests (#5892)
2575da7 
- Avoid clashing test mocks of QuantumEngineServiceClient by limiting
  mocking to the relevant test module.
- Enable test reordering by pytest-randomly.

Fixes #5870.
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@pavoljuhas @rht
untangle entangled tests (quantumlib#5892)
afd49cf 
- Avoid clashing test mocks of QuantumEngineServiceClient by limiting
  mocking to the relevant test module.
- Enable test reordering by pytest-randomly.

Fixes quantumlib#5870.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

untangle entangled tests pavoljuhas/Cirq
1 participant
@pavoljuhas