Add Quantum Fourier Transform #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PhaseGradientGate, QuantumFourierTransformGate, and QFT method - QFT does not define _apply_unitary_ or _unitary_ because the most efficient way to get them is actually via the decomposition - Add exponent_qubit_index to CircuitDiagramInfo - Update ControlledOperation _circuit_diagram_info_ to forward exponent_qubit_index - Add _circuit_diagram_info_ to _InverseCompositeGate - Update phase_estimator example to use built-in QFT - Update hhl example to use built-in QFT - Add `big_endian_bits` option to `ApplyUnitaryArgs.subspace_index`
# Conflicts: # cirq/protocols/apply_unitary_test.py
vtomole
reviewed
Sep 20, 2019
cirq/ops/fourier_transform.py
Outdated
|
|
||
| def __repr__(self): | ||
| return ('cirq.QuantumFourierTransformGate(num_qubits={!r}, ' | ||
| 'without_reverse=False)'.format(self._num_qubits, |
There was a problem hiding this comment.
How will self._without_reverse .format if you hardcode it to False?
There was a problem hiding this comment.
Whooooops. Added the true case to the test battery inputs and fixed this.
mpharrigan
reviewed
Sep 20, 2019
cirq/ops/fourier_transform.py
Outdated
| exponent_qubit_index=0) | ||
|
|
||
|
|
||
| def QFT(*qubits: 'cirq.Qid', without_reverse: bool = False) -> 'cirq.Operation': |
There was a problem hiding this comment.
should this be lowercase?
There was a problem hiding this comment.
I was trying to make it appear the same as e.g. cirq.H and cirq.SWAP. A user learning the API won't be aware that it's a function instead of a global constant (and isn't a function technically a global constant anyways?).
There was a problem hiding this comment.
@mpharrigan Any other issue?
viathor
requested changes
Sep 24, 2019
viathor
approved these changes
Sep 24, 2019
vtomole
approved these changes
Sep 24, 2019
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
big_endian_bitsoption toApplyUnitaryArgs.subspace_indexThis one had snuck into a couple examples as redundant code. It's also one that I've seen people ask about.