Fix PauliString.pass_operations_over not supporting common gates
#2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `_decompose_into_clifford_` method to `GateOperation` - Add `_decompose_into_clifford_with_qubits_` method to several common gates - Add `PauliString.conjugated_by`, which accepts an `OP_TREE` defining a composite Clifford operation in Circuit order. This differs from `pass_ops_over`, because `pass_ops_over` which takes a list of operations in reverse circuit order (which is confusing). - Fix op_gate_isinstance type annotation not allowing type tuples - Add `PauliString.dense` method Code such as the following now works: ``` a, b = cirq.LineQubit.range(2) print(cirq.X(a).pass_operations_over([cirq.H(a)])) print(cirq.X(a).conjugated_by([cirq.H(a), cirq.CNOT(a, b)])) ``` ``` Z(0) Z(0)*X(1) ``` Fixes #2179
|
Reviewers: please check that |
|
I'm excited for The various decompose methods: this seems like it could be simplified/generalized with the long-talked-about notion of gatesets |
|
Yes, I kept the decompose methods private without a publicly exposed method because I didn't want to commit to the interface yet. |
|
is anything blocking this? |
|
@mpharrigan Nothing except actually getting a review of it. |
# Conflicts: # cirq/ops/common_gates.py # cirq/ops/gate_operation.py # cirq/ops/pauli_string.py
mpharrigan
approved these changes
Oct 29, 2019
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_decompose_into_clifford_method toGateOperation_decompose_into_clifford_with_qubits_method to several common gatesPauliString.conjugated_by, which accepts anOP_TREEdefining a composite Clifford operation in Circuit order. This differs frompass_ops_over, becausepass_ops_overtakes a list of operations in reverse circuit order (which is confusing).PauliString.densemethodCode such as the following now works:
Fixes #2179