Enable serialization of non-GridQubits. #2966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the simulator accept arbitrary strings right now? |
Yes - it populates a map of qubits to string IDs with no parsing/validation on the IDs. This will probably misbehave if you mix e.g. |
dabacon
requested changes
May 7, 2020
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
* Enable serialization of non-GridQubits. * Lint fixes for serializer. * LineQubit proto IDs must be digits-only. * Add coverage. * named_qubit_* -> qubit_* * Fix lint error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1325.
Most of the work was already done here - the only remaining effort was to remove checks and add a mux for the deserialize methods. This does have a noticeable side-effect: this code now accepts any proto ID as a valid qubit, since NamedQubit has no restrictions on the strings allowed as names.
As an aside, it's a little odd that we use
x_ynotation for GridQubits, whenint('1_2')returns12. This makes parsing strings as different qubit types order-dependent.