Skip to content

temporary fix for chemistry notebook #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 23, 2020
Merged

temporary fix for chemistry notebook #3626

merged 3 commits into from
Dec 23, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Dec 23, 2020

Fixes #3625.

@balopat balopat requested review from cduck, vtomole and a team as code owners December 23, 2020 00:12
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Dec 23, 2020
viathor
viathor approved these changes Dec 23, 2020
View reviewed changes
docs/tutorials/educators/chemistry.ipynb
@@ -79,7 +79,7 @@
},
"outputs": [],
"source": [
"!pip install openfermion openfermioncirq pyscf openfermionpyscf --quiet"
"!pip install openfermion==0.11.0 openfermioncirq pyscf openfermionpyscf==0.4 --quiet"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: I'd leave a TODO with issue number so folks don't have to dig too much to find out the reason for this and whether or not it's ready for cleanup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!! I will create an issue and assign it to @rmlarose :)
The TODO would get into the site https://quantumai.google/cirq/tutorials/educators/chemistry - so I'd rather not put a TODO in a cell there.

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Dec 23, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Dec 23, 2020
@CirqBot CirqBot merged commit 888d535 into quantumlib:master Dec 23, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Dec 23, 2020
@balopat balopat mentioned this pull request Dec 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chemistry notebook failing after OpenFermion release
3 participants
@balopat @viathor @CirqBot