Sync _has_stabilizer_effect_ implementations and use that for Clifford checks #3656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in CliffordSimulator and gates
95-martin-orion
approved these changes
Jan 20, 2021
| @@ -217,6 +217,9 @@ def _from_json_dict_(cls, num_qubits, key, invert_mask, qid_shape=None, **kwargs | |||
| qid_shape=None if qid_shape is None else tuple(qid_shape), | |||
| ) | |||
|
|
|||
| def _has_stabilizer_effect_(self) -> Optional[bool]: | |||
| return True | |||
There was a problem hiding this comment.
Is this correct? I had a vague impression that measurements, being non-unitary, could not be stabilizers, but it's possible I'm thinking of a different property.
There was a problem hiding this comment.
Yeah, that would be the Clifford group. Stabilizer = Clifford+measurement
Reference: https://www.scottaaronson.com/papers/chp6.pdf Fig 1 and the paragraph below it. Was initially just following the StabilizerState paper but this one seems to have a more succinct definition.
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings has_stabilizer_effect protocol in line with actual implementations so that it can be used in all Clifford eligibility checks instead of a patchwork of custom conditions.
#2423